Show differential-pair connection warnings in netlist checks - #4042
Open
0hmX wants to merge 4 commits into
Open
Conversation
0hmX
marked this pull request as ready for review
August 5, 2026 11:23
…al-pair-netlist-warnings # Conflicts: # bun.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to tscircuit/core#3011 and its wording refinement in tscircuit/core#3017.
What changed
source_property_ignored_warningrecords forpositiveConnectionandnegativeConnectionas netlist diagnostics.type/warning_typemetadata over legacyerror_typemetadata.tsci check netlist <file>.resolveInputFilePathand source-generation workflow.tscircuit@0.0.2233-libonly, which includes the merged implementation and wording through@tscircuit/core@0.0.1602.Runtime flow
tsci check netlist <file>resolves the supplied file or the project entrypoint.tscircuit, falling back to its bundled dependency.SourceDesignRuleChecksand stores the differential-pair diagnostic as asource_property_ignored_warningin Circuit JSON.For an ambiguous named trace, the diagnostic explains that the trace's connection has more than two terminal pins and lists those pins. It does not recommend removing a connection or changing to a pin selector.
Why
The Circuit JSON record currently uses the generic
source_property_ignored_warningtype, so category inference alone does not identify it as a netlist diagnostic. The explicit property switch keeps the exception narrow and readable until Circuit JSON has a dedicated differential-pair diagnostic type or category.Validation
.tsxCore-to-CLI warning generation using Core0.0.1602bunx tsc --noEmitgit diff --check